<html>
<head><meta charset="utf-8"><title>PR labels · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html">PR labels</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="195578281"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195578281" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195578281">(Apr 28 2020 at 15:10)</a>:</h4>
<p>We might want to have some PR labels like <code>rustc</code> has (<code>S-waiting-on-review</code>, <code>S-waiting-on-author</code>, <code>S-inactive</code>). We have 21 open PRs now -- that's quite higher than what we used to.</p>



<a name="195578358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195578358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195578358">(Apr 28 2020 at 15:11)</a>:</h4>
<p>TBH, I am pretty anti-label myself</p>



<a name="195578399"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195578399" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195578399">(Apr 28 2020 at 15:11)</a>:</h4>
<p>Welp, okay :-)</p>



<a name="195578480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195578480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195578480">(Apr 28 2020 at 15:12)</a>:</h4>
<p>Like, I don't find labels useful for me. I do find <code>E-</code> labels useful for contributors, that's why I use them</p>



<a name="195578612"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195578612" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195578612">(Apr 28 2020 at 15:12)</a>:</h4>
<p>Isn't it hard to keep track of those that still need to be reviewed?</p>



<a name="195578941"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195578941" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195578941">(Apr 28 2020 at 15:15)</a>:</h4>
<p>It is, but it's because there are more PRs that I can comfortably review, not because they are unlabled.</p>



<a name="195579269"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195579269" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195579269">(Apr 28 2020 at 15:17)</a>:</h4>
<p>Fair enough. It might end up a moot point anyway when the repo is moved to the rust-lang org.</p>



<a name="195579933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195579933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195579933">(Apr 28 2020 at 15:22)</a>:</h4>
<p>it'll still be a separate repo though</p>



<a name="195580104"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195580104" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195580104">(Apr 28 2020 at 15:23)</a>:</h4>
<p>I hope so :D. Well, we can revisit this when we reach 80 active PRs <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span>.</p>



<a name="195580348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195580348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195580348">(Apr 28 2020 at 15:25)</a>:</h4>
<p>TBH, I feel like there might be a blind spot for me? I sincerely don't understand why so many projects use so many different labels :) </p>
<p>If other contributors find labels useful, than we can add them!</p>
<p>Though, as usual, I think that it's more likely that the world is insane rather than me :) So I'll need a pretty strong arguments from other team members to convince me that yes, labels really help them :)</p>



<a name="195581949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195581949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195581949">(Apr 28 2020 at 15:35)</a>:</h4>
<p>I find <code>A-ty</code> labels useful to see the type system bugs, that's why I'm adding them <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span> for PRs, I think in the current state maintaining the labels would be more work than it saves</p>



<a name="195582051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195582051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195582051">(Apr 28 2020 at 15:36)</a>:</h4>
<p>yeah, it's also true that y'all can just silently add labels, and i won't notice :D</p>



<a name="195597379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195597379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Edwin Cheng <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195597379">(Apr 28 2020 at 17:20)</a>:</h4>
<p><code>A-macro</code> labels is very useful for me to find what bugs I have to fix :) and that's it.</p>



<a name="195597438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195597438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195597438">(Apr 28 2020 at 17:20)</a>:</h4>
<p>Ok, every contributor is allowed to have <strong>one</strong> favorite label /s :D</p>



<a name="195597908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195597908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195597908">(Apr 28 2020 at 17:23)</a>:</h4>
<p><code>A-the-label-that-every-issue-and-pr-must-have-to-make-matklad-happy</code> <span aria-label="smile" class="emoji emoji-263a" role="img" title="smile">:smile:</span></p>



<a name="195598001"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195598001" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Edwin Cheng <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195598001">(Apr 28 2020 at 17:24)</a>:</h4>
<p>OTOH, the problem of github <code>Assignees</code> is that it might prevent new contributors to submit PR for that issue.</p>



<a name="195598059"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195598059" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195598059">(Apr 28 2020 at 17:24)</a>:</h4>
<p><span class="user-mention silent" data-user-id="133247">bjorn3</span> <a href="#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/PR.20labels/near/195597908" title="#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/PR.20labels/near/195597908">said</a>:</p>
<blockquote>
<p><code>A-the-label-that-every-issue-and-pr-must-have-to-make-matklad-happy</code> <span aria-label="smile" class="emoji emoji-263a" role="img" title="smile">:smile:</span></p>
</blockquote>
<p>What did I start? :-(</p>



<a name="195599587"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195599587" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Bastien Orivel <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195599587">(Apr 28 2020 at 17:35)</a>:</h4>
<p>Honestly, regarding labels, at work we have a "Need changes" label which is very useful to quickly find PRs that you don't need to review at the moment. But I guess it doesn't work if contributors can't remove it themselves</p>



<a name="195599759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/PR%20labels/near/195599759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/PR.20labels.html#195599759">(Apr 28 2020 at 17:36)</a>:</h4>
<p>Yeah, the onus would be on the triagers to update the labels</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>